Remove reset usages and remaining method from SearchShardIterator #121934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remaining is used in tests only since the recent change to counting in AbstractSearchAsyncAction. reset was used in a couple of places where it does not seem like it's needed anymore.
javanna
changed the title
javanna
added
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
force-pushed
the
refactoring/dry_search_shard_iterator
branch
from
03d15d4 to
edb111d
Compare
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining is used in tests only since the recent change to counting in AbstractSearchAsyncAction.
reset was used in a couple of places where it does not seem like it's needed anymore. The only leftover usage is valid and we need to come up with a replacement if we want to remove it.